From 07d4393d2733607c42c6f56be042c5b050bd9da1 Mon Sep 17 00:00:00 2001
From: wukko <me@wukko.me>
Date: Wed, 2 Apr 2025 21:22:01 +0600
Subject: [PATCH] web/Omnibox: don't rerender omnibox buttons

this prevents unnecessary listener creation on valid/invalid link spam
---
 web/src/components/save/Omnibox.svelte | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/web/src/components/save/Omnibox.svelte b/web/src/components/save/Omnibox.svelte
index 0849ec64..0847f417 100644
--- a/web/src/components/save/Omnibox.svelte
+++ b/web/src/components/save/Omnibox.svelte
@@ -170,17 +170,13 @@
             disabled={isDisabled}
         />
 
-        {#if clearVisible}
-            <ClearButton click={() => ($link = "")} />
-        {/if}
-        {#if downloadable}
-            <DownloadButton
-                url={$link}
-                bind:this={downloadButton}
-                bind:disabled={isDisabled}
-                bind:loading={isLoading}
-            />
-        {/if}
+        <ClearButton click={() => ($link = "")} />
+        <DownloadButton
+            url={$link}
+            bind:this={downloadButton}
+            bind:disabled={isDisabled}
+            bind:loading={isLoading}
+        />
     </div>
 
     <div id="action-container">
@@ -239,6 +235,14 @@
         flex: 1;
     }
 
+    #input-container:not(.clear-visible) :global(#clear-button) {
+        display: none;
+    }
+
+    #input-container:not(.downloadable) :global(#download-button) {
+        display: none;
+    }
+
     #input-container.clear-visible {
         padding-right: var(--input-padding);
     }