From 3d2473d8ef4f3f4bd2b77713be13dcba0c0133a9 Mon Sep 17 00:00:00 2001 From: wukko Date: Sat, 28 Jun 2025 16:44:28 +0600 Subject: [PATCH] web/audio-sub-language: refactor to avoid code duplication --- web/src/lib/settings/audio-sub-language.ts | 27 +++++++++++----------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/web/src/lib/settings/audio-sub-language.ts b/web/src/lib/settings/audio-sub-language.ts index 3e9d23e4..61653844 100644 --- a/web/src/lib/settings/audio-sub-language.ts +++ b/web/src/lib/settings/audio-sub-language.ts @@ -44,11 +44,11 @@ const namedLanguages = ( name = get(t)("settings.subtitles.none"); break; default: { - let intlName = "unknown"; + let intlName; try { - intlName = new Intl.DisplayNames([lang], { type: 'language' }).of(lang) || "unknown"; + intlName = new Intl.DisplayNames([lang], { type: 'language' }).of(lang); } catch { /* */ }; - name = `${intlName} (${lang})`; + name = `${intlName || "unknown"} (${lang})`; break; } } @@ -69,16 +69,15 @@ export const namedSubtitleLanguages = () => { } export const getBrowserLanguage = (): YoutubeDubLang => { - if (typeof navigator === 'undefined') - return "original"; - - const browserLanguage = navigator.language as YoutubeDubLang; - if (youtubeDubLanguages.includes(browserLanguage)) - return browserLanguage; - - const shortened = browserLanguage.split('-')[0] as YoutubeDubLang; - if (youtubeDubLanguages.includes(shortened)) - return shortened; - + if (typeof navigator !== 'undefined') { + const browserLanguage = navigator.language as YoutubeDubLang; + if (youtubeDubLanguages.includes(browserLanguage)) { + return browserLanguage; + } + const shortened = browserLanguage.split('-')[0] as YoutubeDubLang; + if (youtubeDubLanguages.includes(shortened)) { + return shortened; + } + } return "original"; }