From 5d7524220dfdd73fbc8ae3c9086bfb11a2f93c5e Mon Sep 17 00:00:00 2001
From: Alec Armbruster <35377827+alectrocute@users.noreply.github.com>
Date: Fri, 27 Sep 2024 16:28:16 -0700
Subject: [PATCH] remove description (not needed lol) and optimize naming
 convention for new setting

---
 web/i18n/en/settings.json                       | 5 +----
 web/src/components/sidebar/Sidebar.svelte       | 2 +-
 web/src/routes/+layout.svelte                   | 2 +-
 web/src/routes/settings/appearance/+page.svelte | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/web/i18n/en/settings.json b/web/i18n/en/settings.json
index d99535c5..046d481d 100644
--- a/web/i18n/en/settings.json
+++ b/web/i18n/en/settings.json
@@ -16,10 +16,7 @@
     "theme.light": "light",
     "theme.dark": "dark",
     "theme.description": "auto theme switches between light and dark themes depending on your device's display mode.",
-
-    "sidebar": "sidebar",
-    "sidebar.dark.title": "dark sidebar",
-    "sidebar.dark.description": "by default, the sidebar will be dark in light theme. if you'd prefer it to match the light theme, enable this option.",
+    "theme.darksidebar": "dark sidebar",
 
     "video.quality": "video quality",
     "video.quality.max": "8k+",
diff --git a/web/src/components/sidebar/Sidebar.svelte b/web/src/components/sidebar/Sidebar.svelte
index 880faece..a135207d 100644
--- a/web/src/components/sidebar/Sidebar.svelte
+++ b/web/src/components/sidebar/Sidebar.svelte
@@ -29,7 +29,7 @@
 <nav
     id="sidebar"
     aria-label={$t("a11y.tabs.tab_panel")}
-    class:always-dark={$settings.appearance.darkSidebar}
+    class:dark={$settings.appearance.darkSidebar}
 >
     <CobaltLogo />
     <div id="sidebar-tabs" role="tablist">
diff --git a/web/src/routes/+layout.svelte b/web/src/routes/+layout.svelte
index a006686c..369f9b4c 100644
--- a/web/src/routes/+layout.svelte
+++ b/web/src/routes/+layout.svelte
@@ -225,7 +225,7 @@
     }
 
     :global([data-theme="dark"]),
-    :global(#sidebar.always-dark) {
+    :global(#sidebar.dark) {
         --sidebar-bg: #101010;
         --sidebar-text: #f4f4f4;
         --sidebar-highlight: #f4f4f4;
diff --git a/web/src/routes/settings/appearance/+page.svelte b/web/src/routes/settings/appearance/+page.svelte
index e73574cf..ff14c408 100644
--- a/web/src/routes/settings/appearance/+page.svelte
+++ b/web/src/routes/settings/appearance/+page.svelte
@@ -29,8 +29,7 @@
         <SettingsToggle
             settingContext="appearance"
             settingId="darkSidebar"
-            title={$t("settings.sidebar.dark.title")}
-            description={$t("settings.sidebar.dark.description")}
+            title={$t("settings.theme.darksidebar")}
         />
     {/if}
 </SettingsCategory>