From 866427a7a79d66d5f6762851faccf34b1e3254d8 Mon Sep 17 00:00:00 2001 From: wukko Date: Mon, 28 Oct 2024 16:55:44 +0600 Subject: [PATCH] api/youtube: fix local variable overlap --- api/src/processing/services/youtube.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/api/src/processing/services/youtube.js b/api/src/processing/services/youtube.js index f95f0bc2..ebf4c6f8 100644 --- a/api/src/processing/services/youtube.js +++ b/api/src/processing/services/youtube.js @@ -291,7 +291,7 @@ export default async function(o) { const checkBestVideo = (i) => (i.has_video && i.content_length); const checkBestAudio = (i) => (i.has_audio && i.content_length && i.is_original); - const checkNoMedia = (video, audio) => (!video && !o.isAudioOnly) || (!audio && o.isAudioOnly); + const checkNoMedia = (vid, aud) => (!vid && !o.isAudioOnly) || (!aud && o.isAudioOnly); const earlyBestVideo = adaptive_formats.find(i => checkBestVideo(i)); const earlyBestAudio = adaptive_formats.find(i => checkBestAudio(i)); @@ -331,9 +331,8 @@ export default async function(o) { }) } - const quality = o.quality === "max" ? "9000" : o.quality; const bestQuality = qual(bestVideo); - const useBestQuality = Number(quality) > Number(bestQuality); + const useBestQuality = quality > bestQuality; video = useBestQuality ? bestVideo : adaptive_formats.find(i => qual(i) === quality && checkBestVideo(i)