mirrors/cobalt
1
0
Fork 0
mirror of https://github.com/imputnet/cobalt.git synced 2025-06-28 09:28:29 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

api/stream: add Transfer-Encoding header to tunnel responses

Browse Source 
For HTTP/1.1 when the length of the content isn't known, you must send
the header `Transfer-Encoding: chunked`, so the client knows that it
needs to process the response in parts (chunks). This header is
deprecated in HTTP/2, and maybe not neccessary when using a proxy
(nginx, haproxy, etc), but neccesary when accesing cobalt directly.
https://en.wikipedia.org/wiki/Chunked_transfer_encoding
This commit is contained in:
Andres Perez 2025-06-11 19:56:42 -04:00
parent 35530459b6
commit c26144403c
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api/src/core/api.js
View File

@ -276,7 +276,8 @@ export const runAPI = async (express, app, __dirname, isPrimary = true) => {
methods: ['GET'], methods: ['GET'],
exposedHeaders: [ exposedHeaders: [
'Estimated-Content-Length', 'Estimated-Content-Length',
'Content-Disposition' 'Content-Disposition',
'Transfer-Encoding'
], ],
...corsConfig, ...corsConfig,
})); }));

4
api/src/stream/types.js
View File

@ -156,6 +156,7 @@ const merge = async (streamInfo, res) => {
res.setHeader('Connection', 'keep-alive'); res.setHeader('Connection', 'keep-alive');
res.setHeader('Content-Disposition', contentDisposition(streamInfo.filename)); res.setHeader('Content-Disposition', contentDisposition(streamInfo.filename));
res.setHeader('Estimated-Content-Length', await estimateTunnelLength(streamInfo)); res.setHeader('Estimated-Content-Length', await estimateTunnelLength(streamInfo));
res.setHeader('Transfer-Encoding', 'chunked');
pipe(muxOutput, res, shutdown); pipe(muxOutput, res, shutdown);
@ -220,6 +221,7 @@ const remux = async (streamInfo, res) => {
res.setHeader('Connection', 'keep-alive'); res.setHeader('Connection', 'keep-alive');
res.setHeader('Content-Disposition', contentDisposition(streamInfo.filename)); res.setHeader('Content-Disposition', contentDisposition(streamInfo.filename));
res.setHeader('Estimated-Content-Length', await estimateTunnelLength(streamInfo)); res.setHeader('Estimated-Content-Length', await estimateTunnelLength(streamInfo));
res.setHeader('Transfer-Encoding', 'chunked');
pipe(muxOutput, res, shutdown); pipe(muxOutput, res, shutdown);
@ -296,6 +298,7 @@ const convertAudio = async (streamInfo, res) => {
estimateAudioMultiplier(streamInfo) * 1.1 estimateAudioMultiplier(streamInfo) * 1.1
) )
); );
res.setHeader('Transfer-Encoding', 'chunked');
pipe(muxOutput, res, shutdown); pipe(muxOutput, res, shutdown);
res.on('finish', shutdown); res.on('finish', shutdown);
@ -334,6 +337,7 @@ const convertGif = async (streamInfo, res) => {
res.setHeader('Connection', 'keep-alive'); res.setHeader('Connection', 'keep-alive');
res.setHeader('Content-Disposition', contentDisposition(streamInfo.filename)); res.setHeader('Content-Disposition', contentDisposition(streamInfo.filename));
res.setHeader('Estimated-Content-Length', await estimateTunnelLength(streamInfo, 60)); res.setHeader('Estimated-Content-Length', await estimateTunnelLength(streamInfo, 60));
res.setHeader('Transfer-Encoding', 'chunked');
pipe(muxOutput, res, shutdown); pipe(muxOutput, res, shutdown);