stream: use closeRequest instead of abort() directly

This commit is contained in:
dumbmoron 2024-06-23 13:54:16 +00:00
parent 0d82c3e524
commit f54d2d82cb
No known key found for this signature in database
2 changed files with 8 additions and 6 deletions

View File

@ -1,6 +1,6 @@
import { request } from 'undici'; import { request } from 'undici';
import { Readable } from 'node:stream'; import { Readable } from 'node:stream';
import { getHeaders, pipe } from './shared.js'; import { closeRequest, getHeaders, pipe } from './shared.js';
import { handleHlsPlaylist, isHlsRequest } from './internal-hls.js'; import { handleHlsPlaylist, isHlsRequest } from './internal-hls.js';
const CHUNK_SIZE = BigInt(8e6); // 8 MB const CHUNK_SIZE = BigInt(8e6); // 8 MB
@ -26,7 +26,7 @@ async function* readChunks(streamInfo, size) {
const received = BigInt(chunk.headers['content-length']); const received = BigInt(chunk.headers['content-length']);
if (received < expected / 2n) { if (received < expected / 2n) {
streamInfo.controller.abort(); closeRequest(streamInfo.controller);
} }
for await (const data of chunk.body) { for await (const data of chunk.body) {
@ -39,7 +39,7 @@ async function* readChunks(streamInfo, size) {
async function handleYoutubeStream(streamInfo, res) { async function handleYoutubeStream(streamInfo, res) {
const { signal } = streamInfo.controller; const { signal } = streamInfo.controller;
const cleanup = () => (res.end(), streamInfo.controller.abort()); const cleanup = () => (res.end(), closeRequest(streamInfo.controller));
try { try {
const req = await fetch(streamInfo.url, { const req = await fetch(streamInfo.url, {
@ -80,7 +80,7 @@ async function handleYoutubeStream(streamInfo, res) {
async function handleGenericStream(streamInfo, res) { async function handleGenericStream(streamInfo, res) {
const { signal } = streamInfo.controller; const { signal } = streamInfo.controller;
const cleanup = () => (res.end(), streamInfo.controller.abort()); const cleanup = () => (res.end(), closeRequest(streamInfo.controller));
try { try {
const req = await request(streamInfo.url, { const req = await request(streamInfo.url, {
@ -99,7 +99,7 @@ async function handleGenericStream(streamInfo, res) {
res.setHeader(name, value) res.setHeader(name, value)
if (req.statusCode < 200 || req.statusCode > 299) if (req.statusCode < 200 || req.statusCode > 299)
return res.end(); return cleanup();
if (isHlsRequest(req)) { if (isHlsRequest(req)) {
await handleHlsPlaylist(streamInfo, req, res); await handleHlsPlaylist(streamInfo, req, res);
@ -107,6 +107,7 @@ async function handleGenericStream(streamInfo, res) {
pipe(req.body, res, cleanup); pipe(req.body, res, cleanup);
} }
} catch { } catch {
closeRequest(streamInfo.controller);
cleanup(); cleanup();
} }
} }

View File

@ -5,6 +5,7 @@ import { nanoid } from "nanoid";
import { decryptStream, encryptStream, generateHmac } from "../sub/crypto.js"; import { decryptStream, encryptStream, generateHmac } from "../sub/crypto.js";
import { env } from "../config.js"; import { env } from "../config.js";
import { strict as assert } from "assert"; import { strict as assert } from "assert";
import { closeRequest } from "./shared.js";
// optional dependency // optional dependency
const freebind = env.freebindCIDR && await import('freebind').catch(() => {}); const freebind = env.freebindCIDR && await import('freebind').catch(() => {});
@ -109,7 +110,7 @@ export function destroyInternalStream(url) {
const id = url.searchParams.get('id'); const id = url.searchParams.get('id');
if (internalStreamCache[id]) { if (internalStreamCache[id]) {
internalStreamCache[id].controller.abort(); closeRequest(internalStreamCache[id].controller);
delete internalStreamCache[id]; delete internalStreamCache[id];
} }
} }