ded671ea6d
Of the technically four fibers spawned by `create_notification_stream` two of them are wrapped around an ensure clause to always unsubscribe itself from the notification job after an error, or when it simply finishes. The first is the heartbeat fiber, which is also actually the main fiber of the route handler. The second is a fiber that awaits for notification pushes from the notification job through the `connection` channel. When an error occurs within the main heartbeat fiber, the ensure clause is executed and the function will unsubscribe itself from receiving any pushes from the notification job. The problem however is that this could (will almost always actually) occur when the notification receiver fiber is awaiting a value from the notification job. Except the job will no longer be able to send anything to the receiver since they were unsubscribed by the heartbeat fiber just a moment ago. The notification receiver fiber will now block indefinitely. And in doing so will pretty much prevent the entire execution stack of the fiber and the `create_notification_stream` function from getting garbage collected. The IO buffers for the contents of the request and response will stay referenced, the underlying TCP/TLS sockets will become inaccessible and leaked, the parsed structures of the YT's massive JSON objects will stay allocated, etc. This PR simply merges the two into a single fiber, via a select statement ensuring that there will be no concurrency problems. |
||
|---|---|---|
| .github | ||
| assets | ||
| config | ||
| docker | ||
| kubernetes | ||
| locales | ||
| mocks@b55d58dea9 | ||
| screenshots | ||
| scripts | ||
| spec | ||
| src | ||
| .ameba.yml | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| CHANGELOG_legacy.md | ||
| CHANGELOG.md | ||
| docker-compose.yml | ||
| invidious.service | ||
| LICENSE | ||
| Makefile | ||
| README.md | ||
| shard.lock | ||
| shard.yml | ||
| TRANSLATION | ||
| videojs-dependencies.yml | ||
Invidious
An open source alternative front-end to YouTube
Website • Instances list • FAQ • Documentation • Contribute • Donate
Chat with us:
Screenshots
| Player | Preferences | Subscriptions |
|---|---|---|
 |
 |
 |
 |
 |
 |
Features
User features
- Lightweight
- No ads
- No tracking
- No JavaScript required
- Light/Dark themes
- Customizable homepage
- Subscriptions independent from Google
- Notifications for all subscribed channels
- Audio-only mode (with background play on mobile)
- Support for Reddit comments
- Available in many languages, thanks to our translators
Data import/export
- Import subscriptions from YouTube, NewPipe and FreeTube
- Import watch history from YouTube and NewPipe
- Export subscriptions to NewPipe and FreeTube
- Import/Export Invidious user data
Technical features
- Embedded video support
- Developer API
- Does not use official YouTube APIs
- No Contributor License Agreement (CLA)
Quick start
Using Invidious:
- Select a public instance from the list and start watching videos right now!
Hosting Invidious:
Documentation
The full documentation can be accessed online at https://docs.invidious.io/
The documentation's source code is available in this repository: https://github.com/iv-org/documentation
Extensions
We highly recommend the use of Privacy Redirect, a browser extension that automatically redirects YouTube URLs to any Invidious instance and replaces embedded YouTube videos on other websites with Invidious.
The documentation contains a list of browser extensions that we recommended to use along with Invidious.
You can read more here: https://docs.invidious.io/applications/
Contribute
Code
- Fork it ( https://github.com/iv-org/invidious/fork ).
- Create your feature branch (
git checkout -b my-new-feature). - Stage your files (
git add .). - Commit your changes (
git commit -am 'Add some feature'). - Push to the branch (
git push origin my-new-feature). - Create a new pull request ( https://github.com/iv-org/invidious/compare ).
Translations
We use Weblate to manage Invidious translations.
You can suggest new translations and/or correction here: https://hosted.weblate.org/engage/invidious/.
Creating an account is not required, but recommended, especially if you want to contribute regularly. Weblate also allows you to log-in with major SSO providers like GitHub, GitLab, BitBucket, Google, ...
Projects using Invidious
A list of projects and extensions for or utilizing Invidious can be found in the documentation: https://docs.invidious.io/applications/
Liability
We take no responsibility for the use of our tool, or external instances provided by third parties. We strongly recommend you abide by the valid official regulations in your country. Furthermore, we refuse liability for any inappropriate use of Invidious, such as illegal downloading. This tool is provided to you in the spirit of free, open software.
You may view the LICENSE in which this software is provided to you here.
- Limitation of Liability.
IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.