move url parsing to utils method

src/invidious/videos/description.cr

@@ -1,57 +1,6 @@
 require "json"
 require "uri"
 
-def parse_command(command : JSON::Any?, string : String) : String?
-  on_tap = command.dig?("onTap", "innertubeCommand")
-
-  # 3rd party URL, extract original URL from YouTube tracking URL
-  if url_endpoint = on_tap.try &.["urlEndpoint"]?
-    if url_endpoint["url"].as_s.includes? "youtube.com/redirect"
-      youtube_url = URI.parse url_endpoint["url"].as_s
-      original_url = youtube_url.query_params["q"]?
-      if original_url.nil?
-        return ""
-      else
-        return "<a href=\"#{original_url}\">#{original_url}</a>"
-      end
-    else
-      # not a redirect url, some first party url
-      # see https://github.com/iv-org/invidious/issues/3751
-      first_party_url = url_endpoint["url"].as_s
-      return "<a href=\"#{first_party_url.sub("https://www.youtube.com", "")}\">#{first_party_url}</a>"
-    end
-    # 1st party watch URL
-  elsif watch_endpoint = on_tap.try &.["watchEndpoint"]?
-    video_id = watch_endpoint["videoId"].as_s
-    time = watch_endpoint["startTimeSeconds"].as_i
-
-    url = "/watch?v=#{video_id}&t=#{time}s"
-
-    # if string is a timestamp, use the string instead
-    # this is a lazy regex for validating timestamps
-    if /(?:\d{1,2}:){1,2}\d{2}/ =~ string
-      return "<a href=\"#{url}\">#{string}</a>"
-    else
-      return "<a href=\"#{url}\">#{url}</a>"
-    end
-    # hashtag/other browse URLs
-  elsif browse_endpoint = on_tap.try &.dig?("commandMetadata", "webCommandMetadata")
-    url = browse_endpoint["url"].try &.as_s
-
-    # remove unnecessary character in a channel name
-    if browse_endpoint["webPageType"]?.try &.as_s == "WEB_PAGE_TYPE_CHANNEL"
-      name = string.match(/@[\w\d.-]+/)
-      if name.try &.[0]?
-        return "<a href=\"#{url}\">#{name.try &.[0]}</a>"
-      end
-    end
-
-    return "<a href=\"#{url}\">#{string}</a>"
-  end
-
-  return "(unknown YouTube desc command)"
-end
-
 private def copy_string(str : String::Builder, iter : Iterator, count : Int) : Int
   copied = 0
   while copied < count
@@ -68,7 +17,7 @@ private def copy_string(str : String::Builder, iter : Iterator, count : Int) : I
   return copied
 end
 
-def parse_description(desc : JSON::Any?) : String?
+def parse_description(desc, video_id : String) : String?
   return "" if desc.nil?
 
   content = desc["content"].as_s
@@ -100,7 +49,11 @@ def parse_description(desc : JSON::Any?) : String?
         copy_string(str2, iter, cmd_length)
       end
 
-      str << parse_command(command, cmd_content)
+      link = cmd_content
+      if on_tap = command.dig?("onTap", "innertubeCommand")
+        link = parse_link_endpoint(on_tap, cmd_content, video_id)
+      end
+      str << link
       index += cmd_length
     end
 

src/invidious/videos/parser.cr

@@ -287,7 +287,7 @@ def parse_video_info(video_id : String, player_response : Hash(String, JSON::Any
   # description_html = video_secondary_renderer.try &.dig?("description", "runs")
   #  .try &.as_a.try { |t| content_to_comment_html(t, video_id) }
 
-  description_html = parse_description(video_secondary_renderer.try &.dig?("attributedDescription"))
+  description_html = parse_description(video_secondary_renderer.try &.dig?("attributedDescription"), video_id)
 
   # Video metadata