[cleanup] Deprecate various options (#13821)

Closes #14198, Closes #12909
Authored by: seproDev

test/parameters.json

@@ -36,7 +36,6 @@
     "verbose": true,
     "writedescription": false,
     "writeinfojson": true,
-    "writeannotations": false,
     "writelink": false,
     "writeurllink": false,
     "writewebloclink": false,

test/test_websockets.py

@@ -20,7 +20,7 @@ import random
 import ssl
 import threading
 
-from yt_dlp import socks, traverse_obj
+from yt_dlp import socks
 from yt_dlp.cookies import YoutubeDLCookieJar
 from yt_dlp.dependencies import websockets
 from yt_dlp.networking import Request
@@ -32,6 +32,7 @@ from yt_dlp.networking.exceptions import (
     SSLError,
     TransportError,
 )
+from yt_dlp.utils.traversal import traverse_obj
 from yt_dlp.utils.networking import HTTPHeaderDict
 
 TEST_DIR = os.path.dirname(os.path.abspath(__file__))

test/test_write_annotations.py.disabled

@@ -1,77 +0,0 @@
-#!/usr/bin/env python3
-
-# Allow direct execution
-import os
-import sys
-import unittest
-
-sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
-
-
-import xml.etree.ElementTree
-
-import yt_dlp.extractor
-import yt_dlp.YoutubeDL
-from test.helper import get_params, is_download_test, try_rm
-
-
-class YoutubeDL(yt_dlp.YoutubeDL):
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-        self.to_stderr = self.to_screen
-
-
-params = get_params({
-    'writeannotations': True,
-    'skip_download': True,
-    'writeinfojson': False,
-    'format': 'flv',
-})
-
-
-TEST_ID = 'gr51aVj-mLg'
-ANNOTATIONS_FILE = TEST_ID + '.annotations.xml'
-EXPECTED_ANNOTATIONS = ['Speech bubble', 'Note', 'Title', 'Spotlight', 'Label']
-
-
-@is_download_test
-class TestAnnotations(unittest.TestCase):
-    def setUp(self):
-        # Clear old files
-        self.tearDown()
-
-    def test_info_json(self):
-        expected = list(EXPECTED_ANNOTATIONS)  # Two annotations could have the same text.
-        ie = yt_dlp.extractor.YoutubeIE()
-        ydl = YoutubeDL(params)
-        ydl.add_info_extractor(ie)
-        ydl.download([TEST_ID])
-        self.assertTrue(os.path.exists(ANNOTATIONS_FILE))
-        annoxml = None
-        with open(ANNOTATIONS_FILE, encoding='utf-8') as annof:
-            annoxml = xml.etree.ElementTree.parse(annof)
-        self.assertTrue(annoxml is not None, 'Failed to parse annotations XML')
-        root = annoxml.getroot()
-        self.assertEqual(root.tag, 'document')
-        annotationsTag = root.find('annotations')
-        self.assertEqual(annotationsTag.tag, 'annotations')
-        annotations = annotationsTag.findall('annotation')
-
-        # Not all the annotations have TEXT children and the annotations are returned unsorted.
-        for a in annotations:
-            self.assertEqual(a.tag, 'annotation')
-            if a.get('type') == 'text':
-                textTag = a.find('TEXT')
-                text = textTag.text
-                self.assertTrue(text in expected)  # assertIn only added in python 2.7
-                # remove the first occurrence, there could be more than one annotation with the same text
-                expected.remove(text)
-        # We should have seen (and removed) all the expected annotation texts.
-        self.assertEqual(len(expected), 0, 'Not all expected annotations were found.')
-
-    def tearDown(self):
-        try_rm(ANNOTATIONS_FILE)
-
-
-if __name__ == '__main__':
-    unittest.main()