mirror of
				https://github.com/yt-dlp/yt-dlp.git
				synced 2025-10-31 06:35:12 +00:00 
			
		
		
		
	[YoutubeDL] Temporary fix for subprocess encoding issues on python2 @ Windows (Closes #4787)
For now filenames will be encoded with preferrefencoding before written to disk
This commit is contained in:
		| @@ -543,6 +543,11 @@ class YoutubeDL(object): | |||||||
|             outtmpl = self.params.get('outtmpl', DEFAULT_OUTTMPL) |             outtmpl = self.params.get('outtmpl', DEFAULT_OUTTMPL) | ||||||
|             tmpl = compat_expanduser(outtmpl) |             tmpl = compat_expanduser(outtmpl) | ||||||
|             filename = tmpl % template_dict |             filename = tmpl % template_dict | ||||||
|  |             # Temporary fix for #4787 | ||||||
|  |             # 'Treat' all problem characters by passing filename through preferredencoding | ||||||
|  |             # to workaround encoding issues with subprocess on python2 @ Windows | ||||||
|  |             if sys.version_info < (3, 0) and sys.platform == 'win32': | ||||||
|  |                 filename = encodeFilename(filename, True).decode(preferredencoding()) | ||||||
|             return filename |             return filename | ||||||
|         except ValueError as err: |         except ValueError as err: | ||||||
|             self.report_error('Error in output template: ' + str(err) + ' (encoding: ' + repr(preferredencoding()) + ')') |             self.report_error('Error in output template: ' + str(err) + ' (encoding: ' + repr(preferredencoding()) + ')') | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Sergey M․
					Sergey M․