From 6729562666392f22430e170d7645ede5164c96f4 Mon Sep 17 00:00:00 2001 From: Rohit Date: Wed, 17 Jan 2024 21:58:25 +0530 Subject: [PATCH] asked changes --- yt_dlp/postprocessor/embedthumbnail.py | 2 -- yt_dlp/postprocessor/ffmpeg.py | 12 +++++------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/yt_dlp/postprocessor/embedthumbnail.py b/yt_dlp/postprocessor/embedthumbnail.py index a1a21c368..74eff81ef 100644 --- a/yt_dlp/postprocessor/embedthumbnail.py +++ b/yt_dlp/postprocessor/embedthumbnail.py @@ -96,8 +96,6 @@ def run(self, info): try: self._report_run('mutagen', filename) audio = mutagen.id3.ID3(filename) - if 'APIC' in audio: - del audio['APIC'] with open(thumbnail_filename, 'rb') as thumbfile: audio['APIC'] = mutagen.id3.APIC( encoding=mutagen.id3.Encoding.UTF8, mime='image/%s' % thumbnail_ext, type=3, diff --git a/yt_dlp/postprocessor/ffmpeg.py b/yt_dlp/postprocessor/ffmpeg.py index 627958e60..996c821f8 100644 --- a/yt_dlp/postprocessor/ffmpeg.py +++ b/yt_dlp/postprocessor/ffmpeg.py @@ -674,17 +674,15 @@ def embed_lyrics(self, audio_file, sub_dict): if len(sub_dict) > 1: self.report_warning('More than one subtitle file found. Your media player will likely be unable to display all of them.') - if sub_dict[list(sub_dict.keys())[0]]['ext'] != 'lrc': + if not all(sub['ext'] == 'lrc' for sub in sub_dict.values()): raise PostProcessingError('LRC subtitles required. Use "--convert-subs lrc" to convert') - lyrics_list = [] - for lyrics in sub_dict.keys(): - lyrics_list.append(sub_dict[lyrics]['data']) + lyrics_list = [sub['data'] for sub in sub_dict.values()] if audio_file.endswith('.mp3'): + audio = mutagen.id3.ID3(audio_file) for lyrics in lyrics_list: - audio = mutagen.id3.ID3(audio_file) - audio.add(mutagen.id3.USLT(encoding=3, lang='und', desc='', text=lyrics)) - audio.save() + audio.add(mutagen.id3.USLT(encoding=mutagen.id3.Encoding.UTF8, lang='und', text=lyrics)) + audio.save() else: metadata = mutagen.File(audio_file) metadata['©lyr' if audio_file.endswith('.m4a') else 'lyrics'] = lyrics_list