mirrors/yt-dlp
1
0
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2025-07-12 16:28:31 +00:00
Code Issues Projects Releases Wiki Activity

Fix encoding issues in embedthumbnail.py and embed_lyrics()

Browse Source
This commit is contained in:
Rohit 2023-12-29 22:11:18 +05:30
parent 51af60e6d7
commit 823543c2a4
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
yt_dlp/postprocessor/embedthumbnail.py
View File

@ -100,7 +100,7 @@ def run(self, info):
del audio['APIC'] del audio['APIC']
with open(thumbnail_filename, 'rb') as thumbfile: with open(thumbnail_filename, 'rb') as thumbfile:
audio['APIC'] = mutagen.id3.APIC( audio['APIC'] = mutagen.id3.APIC(
encoding=3, mime='image/%s' % thumbnail_ext, type=3, encoding=mutagen.id3.Encoding.UTF8, mime='image/%s' % thumbnail_ext, type=3,
desc=u'Cover (front)', data=thumbfile.read()) desc=u'Cover (front)', data=thumbfile.read())
audio.save() audio.save()
temp_filename = filename # Mutagen saves to the original file temp_filename = filename # Mutagen saves to the original file

4
yt_dlp/postprocessor/ffmpeg.py
View File

@ -672,6 +672,8 @@ def run(self, info):
def embed_lyrics(self, input_files): def embed_lyrics(self, input_files):
audio_file = input_files[0] audio_file = input_files[0]
subs = input_files[1] subs = input_files[1]
if len(input_files) > 2:
self.report_warning('More than one subtitle file found. Only one will be embedded')
if not subs.endswith('.lrc'): if not subs.endswith('.lrc'):
raise PostProcessingError('LRC subtitles required. Use "--convert-subs lrc" to convert') raise PostProcessingError('LRC subtitles required. Use "--convert-subs lrc" to convert')
@ -679,7 +681,7 @@ def embed_lyrics(self, input_files):
lyrics = f.read().strip() lyrics = f.read().strip()
if audio_file.endswith('.mp3'): if audio_file.endswith('.mp3'):
audio = mutagen.id3.ID3(audio_file) audio = mutagen.id3.ID3(audio_file)
audio.add(mutagen.id3.USLT(encoding=3, lang='eng', desc='', text=lyrics)) audio.add(mutagen.id3.USLT(encoding=mutagen.id3.Encoding.UTF8, lang='und', desc='', text=lyrics))
audio.save() audio.save()
else: else:
metadata = mutagen.File(audio_file) metadata = mutagen.File(audio_file)