From 9c70535ef53e429af3c146e4d9ca96ff90f55cd7 Mon Sep 17 00:00:00 2001 From: c-basalt <117849907+c-basalt@users.noreply.github.com> Date: Wed, 25 Jun 2025 19:40:31 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com> --- yt_dlp/extractor/bilibili.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/yt_dlp/extractor/bilibili.py b/yt_dlp/extractor/bilibili.py index 2d9ec060fa..0f5c2c97e4 100644 --- a/yt_dlp/extractor/bilibili.py +++ b/yt_dlp/extractor/bilibili.py @@ -1227,6 +1227,7 @@ class BilibiliSpaceVideoIE(BilibiliSpaceBaseIE): }, 'playlist_mincount': 92, }, { + # Hidden-mode collection 'url': 'https://space.bilibili.com/3669403/video', 'info_dict': { 'id': '3669403', @@ -1301,9 +1302,9 @@ def get_metadata(page_data): } def get_entries(page_data): - for entry in traverse_obj(page_data, ('list', 'vlist')) or []: + for entry in traverse_obj(page_data, ('list', 'vlist', ..., {dict})): if traverse_obj(entry, ('meta', 'attribute')) == 156: - # hidden-mode collection do not show its videos in uploads, extract as playlist instead + # hidden-mode collection doesn't show its videos in uploads; extract as playlist instead yield self.url_result( f'https://space.bilibili.com/{entry["mid"]}/lists/{entry["meta"]["id"]}?type=season', BilibiliCollectionListIE, f'{entry["mid"]}_{entry["meta"]["id"]}')