1
0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2025-10-31 06:35:12 +00:00

[jsinterp, extractor/youtube] Minor fixes

This commit is contained in:
pukkandan
2022-08-30 17:23:59 +05:30
parent 5135ed3d4a
commit d81ba7d491
5 changed files with 30 additions and 14 deletions

View File

@@ -52,6 +52,8 @@ class PhantomJSwrapper:
This class is experimental.
"""
INSTALL_HINT = 'Please download it from https://phantomjs.org/download.html'
_BASE_JS = R'''
phantom.onError = function(msg, trace) {{
var msgStack = ['PHANTOM ERROR: ' + msg];
@@ -110,8 +112,7 @@ class PhantomJSwrapper:
self.exe = check_executable('phantomjs', ['-v'])
if not self.exe:
raise ExtractorError(
'PhantomJS not found, Please download it from https://phantomjs.org/download.html', expected=True)
raise ExtractorError(f'PhantomJS not found, {self.INSTALL_HINT}', expected=True)
self.extractor = extractor
@@ -237,6 +238,6 @@ class PhantomJSwrapper:
except Exception as e:
raise ExtractorError(f'{note} failed: Unable to run PhantomJS binary', cause=e)
if returncode:
raise ExtractorError(f'{note} failed:\n{stderr.strip()}')
raise ExtractorError(f'{note} failed with returncode {returncode}:\n{stderr.strip()}')
return stdout