mirrors/yt-dlp
1
0
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2025-10-31 06:35:12 +00:00
Code Issues Projects Releases Wiki Activity
22,658 Commits 2 Branches 128 Tags
0e539617a41913c7da1edd74fb6543c10ad727b3
Commit Graph

41 Commits

Author SHA1 Message Date
bashonly
d502f4c6d9 [pp/embedthumbnail] Fix embedding with mutagen (#10337) 
Fixes regression in f2a4ea1794

Closes #10335
Authored by: bashonly
 2024-07-02 21:24:17 +00:00
Simon Sawicki
f2a4ea1794 [pp/embedthumbnail] Fix postprocessor (#10248) 
* [compat] Improve `imghdr.what` detection
* [pp/embedthumbnail] Improve imghdr fail message
* [pp/embedthumbnail] Fix AtomicParsley error handling

Authored by: Grub4K
 2024-06-27 16:12:19 +02:00
sepro
add96eb9f8 [cleanup] Add more ruff rules (#10149) 
Authored by: seproDev

Reviewed-by: bashonly <88596187+bashonly@users.noreply.github.com>
Reviewed-by: Simon Sawicki <contact@grub4k.xyz>
 2024-06-12 01:09:58 +02:00
pukkandan
47ab66db0f [docs] Misc Cleanup (#8977) 
Closes #8355, #8944

Authored by: bashonly, Grub4k, Arthurszzz, seproDev, pukkandan

Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: bashonly <bashonly@protonmail.com>
Co-authored-by: Arthurszzz <minecraftgamerarthur@gmail.com>
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
 2024-03-11 00:48:47 +05:30
Neurognostic
8a4cd12c8f [pp/EmbedThumbnail] Support m4v (#7583) 
Authored by: Neurognostic
 2023-07-14 02:09:21 +05:30
Lesmiscore
0f0875ed55 [postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix error on attaching thumbnails and info json for mkv/mka (#6647) 
Authored by: Lesmiscore

Current yt-dlp code never hit this bug, but would hit once filename sanitization gets better
 2023-03-28 01:17:42 +09:00
Noah
e02e6d86db [embedthumbnail] Fix thumbnail name in mp3 (#5163) 
Authored by: How-Bout-No
 2022-10-07 17:34:27 +05:30
pukkandan
b5e9a641f5 [postprocessor/embedthumbnail] Detect libatomicparsley.so 2022-08-11 07:23:36 +05:30
pukkandan
f0c9fb9682 [utils] Popen: Refactor to use contextmanager 
Fixes https://github.com/yt-dlp/yt-dlp/issues/3531#issuecomment-1156223597
 2022-06-16 06:23:50 +05:30
pukkandan
5792c950bf [compat] Implement compat.imghdr 
Python 3.11 deprecates `imghdr` module
 2022-05-17 19:46:01 +05:30
pukkandan
43d7f5a5d0 [EmbedThumbnail] Do not obey -k 2022-05-01 04:58:26 +05:30
pukkandan
1d485a1a79 [cleanup] Misc fixes 
Closes #3565, https://github.com/yt-dlp/yt-dlp/issues/3514#issuecomment-1105944364
 2022-04-29 07:39:33 +05:30
Evan Spensley
7774db5bf9 [EmbedThumbnail] Disable thumbnail conversion for mkv (#3512) 
Closes #3209
Authored by: evansp
 2022-04-21 14:26:10 -07:00
pukkandan
9b8ee23b99 [dependencies] Create module with all dependency imports 2022-04-21 00:48:52 +05:30
pukkandan
f82711587c [cleanup] Sort imports 
Using https://github.com/PyCQA/isort

    isort -m VERTICAL_HANGING_INDENT --py 36 -l 80 --rr -n --tc .
 2022-04-12 05:32:52 +05:30
pukkandan
86e5f3ed2e [cleanup] Upgrade syntax 
Using https://github.com/asottile/pyupgrade

1. `__future__` imports and `coding: utf-8` were removed
2. Files were rewritten with `pyupgrade --py36-plus --keep-percent-format`
3. f-strings were cherry-picked from `pyupgrade --py36-plus`

Extractors are left untouched (except removing header) to avoid unnecessary merge conflicts
 2022-04-12 05:32:51 +05:30
pukkandan
f894294636 [EmbedThumbnail] Do not remove id3v1 tags 2022-04-10 01:21:34 +05:30
pukkandan
397235c52b [ffmpeg] Standardize use of -map 0 
Closes #2182
 2022-01-12 08:52:09 +05:30
pukkandan
77cee0f188 [EmbedThumbnail] Prefer AtomicParsley over ffmpeg if available 2021-12-27 03:49:43 +05:30
pukkandan
d3c93ec2b7 Don't create console for subprocesses on Windows (#1261) 
Closes #1251
 2021-10-20 21:49:40 +05:30
Paul Wrubel
d75201a873 Use os.replace where applicable (#793) 
When using 
```py
os.remove(encodeFilename(filename))
os.rename(encodeFilename(temp_filename), encodeFilename(filename))
```
the `os.remove` need not be atomic and so can be executed arbitrarily compared to the immediately following rename call. It is better to use `os.replace` instead

Authored by: paulwrubel
 2021-08-27 07:57:20 +05:30
pukkandan
00034c146a [embedthumbnail] Fix _get_thumbnail_resolution 2021-07-11 04:46:53 +05:30
pukkandan
15a4fd53d3 [thumbnailsconvertor] Treat jpeg as jpg 2021-06-25 05:36:35 +05:30
pukkandan
e858a9d6d3 [EmbedThumbnail] Add compat-option embed-thumbnail-atomicparsley 
to force use of atomicparsley for embedding thumbnails in mp4

Related: #411
 2021-06-16 22:33:32 +05:30
pukkandan
8326b00aab Allow images formats 
Necessary for #343.

* They are identified by `vcodec=acodec='none'`
* These formats show as the worst in `-F`
* Any postprocessor that expects audio/video will be skipped
* `b*` and all related selectors will skip such formats
* This commit also does not add any selector for downloading such formats. They have to be explicitly requested by the `format_id`. Implementation of a selector is left for when #389 is resolved
 2021-06-13 03:45:53 +05:30
pukkandan
337e0c62f8 [embedthumbnail] Correctly escape filename 
Closes #352
The approach in [1] is faulty as can be seen in the test cases
1. bff857a8af
 2021-05-29 02:31:14 +05:30
pukkandan
885cc0b75c [embedthumbnail] Embed if any thumbnail was downloaded, not just the best 2021-05-29 02:31:14 +05:30
Oliver Freyermuth
f17c702270 [ard] Allow URLs without - before id 
https://github.com/ytdl-org/youtube-dl/pull/29091

Authored by: olifre
 2021-05-23 23:03:08 +05:30
pukkandan
acdecdfaef [embedthumbnail] Embed in mp4/m4a using mutagen 
Code from: https://github.com/ytdl-org/youtube-dl/pull/23525
Co-authored by: tripulse , pukkandan
 2021-05-23 22:16:35 +05:30
louie-github
a927acb1ec [ThumbnailsConvertor] Support conversion to png and make it the default (#333) 
PNG, being a lossless format, should be a better default here compared to JPG since we won't be compressing to a lossy format and losing some of the original image data
PNG is also supported for embedding in all the formats similar to JPEG

Authored by: louie-github
 2021-05-21 23:39:48 +05:30
pukkandan
28b0eb0f65 [cleanup] See desc 
* Remove struct from `embedthumbnail`
* Use bullet lists in readme where numbered list don't make sense
* Fix error introduced in 9c2b75b561 when `ie_result` is `None`
 2021-05-20 18:02:58 +05:30
pukkandan
95131b2176 [embedthumbnail] Add flac support and refactor mutagen code 
https://github.com/ytdl-org/youtube-dl/pull/28894, https://github.com/ytdl-org/youtube-dl/pull/24310
Authored by: tripulse
 2021-05-20 17:51:33 +05:30
pukkandan
4d224a3022 [embedthumbnail] Fix bug where jpeg thumbnails were converted again 
Closes #297
 2021-05-04 22:18:40 +05:30
pukkandan
8fa43c73d8 Add option --convert-thumbnails 
Closes: https://github.com/yt-dlp/yt-dlp/issues/99 https://github.com/yt-dlp/yt-dlp/issues/102
 2021-04-12 02:32:29 +05:30
pukkandan
56d868dbb7 Allow running some postprocessors before actual download 2021-04-12 02:12:46 +05:30
pukkandan
beb4b92a66 More consistent warning messages (#173) 
Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>
 2021-03-20 09:34:52 +05:30
pukkandan
dcf64d43e0 [movefiles] Fix bugs and make more robust 2021-03-18 20:54:53 +05:30
pukkandan
ca87974543 [embedthumbnail] Set mtime correctly 
Related: https://github.com/yt-dlp/yt-dlp/issues/67
 2021-03-14 21:56:04 +05:30
pukkandan
e92caff5d5 Refactor (See desc) 
* Create `FFmpegPostProcessor.real_run_ffmpeg` that can accept multiple input/output files along with switches for each
* Rewrite `cli_configuration_args` and related functions
* Create `YoutubeDL._ensure_dir_exists` - this was previously defined in multiple places
 2021-03-14 20:02:55 +05:30
pukkandan
0e0040519b [embedthumbnail] Fix bug with deleting original thumbnail (Closes #113) 
:ci skip dl
 2021-02-25 18:35:04 +05:30
Pccode66
7a5c1cfe93 Completely change project name to yt-dlp (#85) 
* All modules and binary names are changed
* All documentation references changed
* yt-dlp no longer loads youtube-dlc config files
* All URLs changed to point to organization account

Co-authored-by: Pccode66
Co-authored-by: pukkandan
 2021-02-25 00:15:56 +05:30